-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup NetworkManager dns.conf on Reset #11440
Cleanup NetworkManager dns.conf on Reset #11440
Conversation
Hi @HoKim98. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HoKim98, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
/etc/NetworkManager/conf.d/dns.conf
on reset to ensure that there's no more k8s DNS.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
When initially deploying the cluster using Kubespray, nodelocaldns was enabled. After resetting and redeploying the cluster with nodelocaldns disabled, I noticed that the
/etc/resolv.conf
file still contained the nameserver address of nodelocaldns (nameserver 169.254.25.10). Since I was using NetworkManager, I discovered that it retained the legacy configuration from the previous cluster in the/etc/NetworkManager/conf.d/dns.conf
file. To ensure DNS information is fully reset when resetting the cluster, I propose deleting this file.Does this PR introduce a user-facing change?: