Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crictl images should list all image tags. #157

Closed
Random-Liu opened this issue Oct 13, 2017 · 5 comments
Closed

crictl images should list all image tags. #157

Random-Liu opened this issue Oct 13, 2017 · 5 comments

Comments

@Random-Liu
Copy link
Contributor

Currently we are listing image by id, and only include the first repo tag.

We should organize the information better.

Docker lists all image tags even they have the same id.

@yanxuean
Copy link
Contributor

yanxuean commented Oct 13, 2017

Do It only need to show more? After all crictl already have all image info by client.ListImages.

@yanxuean
Copy link
Contributor

like this ?

$ docker images

REPOSITORY                TAG                 IMAGE ID            CREATED             SIZE
<none>                    <none>              77af4d6b9913        19 hours ago        1.089 GB
committ                   latest              b6fa739cedf5        19 hours ago        1.089 GB
<none>                    <none>              78a85c484f71        19 hours ago        1.089 GB
docker                    latest              30557a29d5ab        20 hours ago        1.089 GB
<none>                    <none>              5ed6274db6ce        24 hours ago        1.089 GB
postgres                  9                   746b819f315e        4 days ago          213.4 MB
postgres                  9.3                 746b819f315e        4 days ago          213.4 MB
postgres                  9.3.5               746b819f315e        4 days ago          213.4 MB
postgres                  latest              746b819f315e        4 days ago          213.4 MB

@Random-Liu
Copy link
Contributor Author

Random-Liu commented Oct 13, 2017

@yanxuean Actually I tried yesterday, docker images doesn't seem to list image pulled by repo digest. Could you verify?

like this ?

Is this docker images output? I don't remember there is <none>.

@yanxuean
Copy link
Contributor

ok, i will try it. The example as above is from the docker 's office document.

@yanxuean
Copy link
Contributor

  1. one imageID with mutiple repoTag
root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# docker images
REPOSITORY                       TAG                 IMAGE ID            CREATED             SIZE
jpetazzo/nsenter                 latest              c16fe938c1a5        15 months ago       371MB
gcr.io/google_containers/pause   3.0                 99e59f495ffa        17 months ago       747kB
gcr.io/google_containers/pause   5.0                 99e59f495ffa        17 months ago       747kB

root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# docker rmi gcr.io/google_containers/pause:5.0
Untagged: gcr.io/google_containers/pause:5.0
root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# docker rmi gcr.io/google_containers/pause:3.0
Untagged: gcr.io/google_containers/pause:3.0
Untagged: gcr.io/google_containers/pause@sha256:0d093c962a6c2dd8bb8727b661e2b5f13e9df884af9945b4cc7088d9350cd3ee
Deleted: sha256:99e59f495ffaa222bfeb67580213e8c28c1e885f1d245ab2bbe3b1b1ec3bd0b2
Deleted: sha256:666604249ff52593858b7716232097daa6d721b7b4825aac8bf8a3f45dfba1ce
Deleted: sha256:7897c392c5f451552cd2eb20fdeadd1d557c6be8a3cd20d0355fb45c1f151738
Deleted: sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef
root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
jpetazzo/nsenter    latest              c16fe938c1a5        15 months ago       371MB
  1. docker image for image pulled by repoDigest
root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# docker pull gcr.io/google_containers/pause@sha256:0d093c962a6c2dd8bb8727b661e2b5f13e9df884af9945b4cc7088d9350cd3ee
sha256:0d093c962a6c2dd8bb8727b661e2b5f13e9df884af9945b4cc7088d9350cd3ee: Pulling from google_containers/pause
a3ed95caeb02: Pull complete 
f11233434377: Pull complete 
Digest: sha256:0d093c962a6c2dd8bb8727b661e2b5f13e9df884af9945b4cc7088d9350cd3ee
Status: Downloaded newer image for gcr.io/google_containers/pause@sha256:0d093c962a6c2dd8bb8727b661e2b5f13e9df884af9945b4cc7088d9350cd3ee
root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# docker images
REPOSITORY                       TAG                 IMAGE ID            CREATED             SIZE
jpetazzo/nsenter                 latest              c16fe938c1a5        15 months ago       371MB
gcr.io/google_containers/pause   <none>              99e59f495ffa        17 months ago       747kB
root@ubuntu:/home/cloud/go/src/k8s.io/kubernetes# 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants