Merge pull request #268 from feiskyer/fix-trunc

Avoid panic when runtimes are using truncated IDs

Author: Random-Liu

cmd/crictl/container.go

@@ -623,7 +623,10 @@ func ListContainers(client pb.RuntimeServiceClient, opts listOptions) error {
 		if !opts.verbose {
 			id := c.Id
 			if !opts.noTrunc {
-				id = strings.TrimPrefix(c.Id, "")[:truncatedIDLen]
+				id = strings.TrimPrefix(c.Id, "")
+				if len(id) > truncatedIDLen {
+					id = id[:truncatedIDLen]
+				}
 			}
 			fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\t%d\n",
 				id, c.Image.Image, ctm, c.State, c.Metadata.Name, c.Metadata.Attempt)

cmd/crictl/image.go

@@ -154,7 +154,10 @@ var listImageCommand = cli.Command{
 				size := units.HumanSizeWithPrecision(float64(image.GetSize_()), 3)
 				id := image.Id
 				if !noTrunc {
-					id = strings.TrimPrefix(image.Id, "sha256:")[:truncatedIDLen]
+					id = strings.TrimPrefix(image.Id, "sha256:")
+					if len(id) > truncatedIDLen {
+						id = id[:truncatedIDLen]
+					}
 				}
 				for _, repoTagPair := range repoTagPairs {
 					if showDigest {

cmd/crictl/sandbox.go

@@ -431,7 +431,10 @@ func ListPodSandboxes(client pb.RuntimeServiceClient, opts listOptions) error {
 			ctm := units.HumanDuration(time.Now().UTC().Sub(createdAt)) + " ago"
 			id := pod.Id
 			if !opts.noTrunc {
-				id = strings.TrimPrefix(pod.Id, "")[:truncatedIDLen]
+				id = strings.TrimPrefix(pod.Id, "")
+				if len(id) > truncatedIDLen {
+					id = id[:truncatedIDLen]
+				}
 			}
 			fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\t%d\n",
 				id, ctm, pod.State, pod.Metadata.Name, pod.Metadata.Namespace, pod.Metadata.Attempt)

cmd/crictl/stats.go

@@ -162,7 +162,10 @@ func ContainerStats(client pb.RuntimeServiceClient, opts statsOptions) error {
 	// Use `+` to work around go vet bug
 	fmt.Fprintln(w, "CONTAINER\tCPU %"+"\tMEM\tDISK\tINODES")
 	for _, s := range r.GetStats() {
-		id := strings.TrimPrefix(s.Attributes.Id, "")[:truncatedIDLen]
+		id := strings.TrimPrefix(s.Attributes.Id, "")
+		if len(id) > truncatedIDLen {
+			id = id[:truncatedIDLen]
+		}
 		cpu := s.GetCpu().GetUsageCoreNanoSeconds().GetValue()
 		mem := s.GetMemory().GetWorkingSetBytes().GetValue()
 		disk := s.GetWritableLayer().GetUsedBytes().GetValue()