Merge pull request #190 from miaoyq/protobuf-obj-using-jsonpb

Use `jsonpb` instead of `json` for protobuf object output

Author: Random-Liu

cmd/crictl/container.go

@@ -533,9 +533,9 @@ func ListContainers(client pb.RuntimeServiceClient, opts listOptions) error {
 
 	switch opts.output {
 	case "json":
-		return outputJSON(r.Containers)
+		return outputProtobufObjAsJSON(r)
 	case "yaml":
-		return outputYAML(r.Containers)
+		return outputProtobufObjAsYAML(r)
 	}
 
 	w := tabwriter.NewWriter(os.Stdout, 20, 1, 3, ' ', 0)

cmd/crictl/image.go

@@ -119,9 +119,9 @@ var listImageCommand = cli.Command{
 
 		switch context.String("output") {
 		case "json":
-			return outputJSON(r.Images)
+			return outputProtobufObjAsJSON(r)
 		case "yaml":
-			return outputYAML(r.Images)
+			return outputProtobufObjAsYAML(r)
 		}
 
 		// output in table format by default.

cmd/crictl/sandbox.go

@@ -364,9 +364,9 @@ func ListPodSandboxes(client pb.RuntimeServiceClient, opts listOptions) error {
 
 	switch opts.output {
 	case "json":
-		return outputJSON(r.Items)
+		return outputProtobufObjAsJSON(r)
 	case "yaml":
-		return outputYAML(r.Items)
+		return outputProtobufObjAsJSON(r)
 	}
 
 	w := tabwriter.NewWriter(os.Stdout, 20, 1, 3, ' ', 0)

cmd/crictl/util.go

@@ -165,33 +165,37 @@ func closeConnection(context *cli.Context) error {
 	return conn.Close()
 }
 
-func outputJSON(v interface{}) error {
-	marshaledJSON, err := json.MarshalIndent(v, "", "  ")
+func protobufObjectToJSON(obj proto.Message) (string, error) {
+	jsonpbMarshaler := jsonpb.Marshaler{EmitDefaults: true, Indent: "  "}
+	marshaledJSON, err := jsonpbMarshaler.MarshalToString(obj)
 	if err != nil {
-		return err
+		return "", err
 	}
-
-	fmt.Println(string(marshaledJSON))
-	return nil
+	return marshaledJSON, nil
 }
 
-func outputYAML(v interface{}) error {
-	marshaledYAML, err := yaml.Marshal(v)
+func outputProtobufObjAsJSON(obj proto.Message) error {
+	marshaledJSON, err := protobufObjectToJSON(obj)
 	if err != nil {
 		return err
 	}
 
-	fmt.Println(string(marshaledYAML))
+	fmt.Println(marshaledJSON)
 	return nil
 }
 
-func protobufObjectToJSON(obj proto.Message) (string, error) {
-	jsonpbMarshaler := jsonpb.Marshaler{EmitDefaults: true, Indent: "  "}
-	marshaledJSON, err := jsonpbMarshaler.MarshalToString(obj)
+func outputProtobufObjAsYAML(obj proto.Message) error {
+	marshaledJSON, err := protobufObjectToJSON(obj)
 	if err != nil {
-		return "", err
+		return err
 	}
-	return marshaledJSON, nil
+	marshaledYAML, err := yaml.JSONToYAML([]byte(marshaledJSON))
+	if err != nil {
+		return err
+	}
+
+	fmt.Println(string(marshaledYAML))
+	return nil
 }
 
 func outputStatusInfo(status proto.Message, info map[string]string, format string) error {