Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Initialize exponentialBackOffOnError by default. #891

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Initialize exponentialBackOffOnError by default. #891

merged 1 commit into from
Jul 30, 2018

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jul 30, 2018

Claim/volume queues are constructed with following rate limiter because exponentialBackOffOnError is false by default, it cannot save failures with RateLimiting feature:

ratelimiter = workqueue.NewMaxOfRateLimiter(
        &workqueue.BucketRateLimiter{Limiter: rate.NewLimiter(rate.Limit(10), 100)},
)

Fixes #890.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2018
@cofyc
Copy link
Contributor Author

cofyc commented Jul 30, 2018

/area lib
/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Jul 30, 2018

/lgtm
TY

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2018
@wongma7 wongma7 merged commit fc25fd3 into kubernetes-retired:master Jul 30, 2018
@cofyc cofyc deleted the fix890 branch October 31, 2018 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@wongma7 wongma7

Labels
area/lib cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cofyc @wongma7 @k8s-ci-robot