-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ProvisionController support for SharedInformers #556
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-ci-robot I've signed the CLA. |
/cc @wongma7 |
96aa613
to
c254b9d
Compare
I've refactored the code to be consistent with the functional options pattern:
|
@wongma7 did you get a chance to look at this? |
c254b9d
to
71c78bb
Compare
71c78bb
to
d790a5d
Compare
I've removed the commit which vendored the additional client-go/informers/* packages (as these were added as part of #578), and rebased. |
/lgtm |
/approve no-issue |
This PR adds support for running the
ProvisionController
withSharedInformers
.This is achieved by introducing a new constructor,
NewProvisionControllerWithConfig()
that enables to optionally pass in shared informers; The existing constructor,NewProvisionController()
, as well as its behavior, are left as they were.Resolves #546.