-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model registry UI installation instructions #4013
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lucas Fernandez <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -26,6 +26,24 @@ Kubeflow Model Registry is available as an opt-in alpha component in Kubeflow Pl | |||
|
|||
If you have deployed the Kubeflow manifests, you may follow [these instructions](https://github.com/kubeflow/manifests/tree/master/apps/model-registry/upstream#readme) to deploy Model Registry; please raise any feedback on [`kubeflow/model-registry`](https://github.com/kubeflow/model-registry/issues). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible a user might do this before ever seeing the notes below. Maybe we need a note here that says see the section below if you are planning to use the Kubeflow UI? Not sure what scenario you would want to have MR in the kubeflow namespace if you plan to use the Kubeflow Platform / Dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I'll get a warning to follow next step if they plan to install MR UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we just need to incorporate @Griffin-Sullivan suggestion. The getting started section could be in a FUP PR.
@@ -7,7 +7,7 @@ weight = 20 | |||
This guide shows how to get started with Model Registry and run a few examples using the | |||
command line or Python clients. | |||
|
|||
At this time, the Model Registry does not include a web-based User Interface (UI), therefore this documentation focuses on backend services and APIs. | |||
<!-- TODO: Check with MR team to see if we include screenshots for a UI "get started" --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucferbux, we can do this in a FUP PR, but as the UI is an important piece of Model Registry, I would suggest figuring out how to mention the UI in this section.
Checklist:
Description of your changes:
Added a Model Registry UI section in under Model Registry.
Issue
Closes: #
Labels