Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added social media icon on readme and footer #3998

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: added social media icon on readme and footer #3998

wants to merge 8 commits into from
+91 −61

Conversation

jaiakash
Copy link
Contributor

@jaiakash jaiakash commented Feb 13, 2025 •
edited
Loading

Fixes #3684
Fixes #3633
Fixes #3683

Hi, I have added

  • X (twitter), Slack, YouTube and KubeFlow CNCF icon in project readme
  • New twitter icon, YouTube and LinkedIn on footer

Screenshot 1:

Screenshot 2025-02-13 at 11 43 29 PM

Screenshot 2:

Screenshot 2025-02-13 at 11 40 26 PM

@jaiakash
feat: added social media icons
636f10a 
Signed-off-by: Akash Jaiswal <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

Hi @jaiakash. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jaiakash jaiakash mentioned this pull request Feb 13, 2025
Open
Arhell
Arhell reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

andreyvelich
andreyvelich reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @hbelmiro @varodrig @juliusvonkohout @franciscojavierarceo @terrytangyuan

README.md
<img src="https://img.shields.io/badge/CNCF%20Landscape-5699C6?logo=cncf&style=social" alt="KubeFlow CNCF Landscape" />
</a>

[![Slack](https://img.shields.io/badge/Slack-4A154B?style=for-the-badge&logo=slack&logoColor=white)](./docs/about/community/#kubeflow-slack-channels)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work, so maybe it is better to use to full link:
https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added full url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the slack link is not working. Agree with @andreyvelich to use https://www.kubeflow.org/docs/about/community/#kubeflow-slack-channels

Copy link
Contributor Author

@jaiakash jaiakash Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in latest commit

README.md

[![Slack](https://img.shields.io/badge/Slack-4A154B?style=for-the-badge&logo=slack&logoColor=white)](./docs/about/community/#kubeflow-slack-channels)
[![LinkedIn](https://img.shields.io/badge/linkedin-%230077B5.svg?style=for-the-badge&logo=linkedin&logoColor=white)](https://www.linkedin.com/company/kubeflow)
[![YouTube](https://img.shields.io/badge/YouTube-%23FF0000.svg?style=for-the-badge&logo=YouTube&logoColor=white)](https://www.youtube.com/kubeflow)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this YouTube channel is more useful since we publish all meetings there
https://www.youtube.com/@KubeflowCommunity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @andreyvelich suggestion to use https://www.youtube.com/@KubeflowCommunity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md
[![LinkedIn](https://img.shields.io/badge/linkedin-%230077B5.svg?style=for-the-badge&logo=linkedin&logoColor=white)](https://www.linkedin.com/company/kubeflow)
[![YouTube](https://img.shields.io/badge/YouTube-%23FF0000.svg?style=for-the-badge&logo=YouTube&logoColor=white)](https://www.youtube.com/kubeflow)
[![X](https://img.shields.io/badge/X-%23000000.svg?style=for-the-badge&logo=X&logoColor=white)](https://x.com/kubeflow/)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this:
https://bsky.app/profile/kubefloworg.bsky.social

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added bluesky

@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 19, 2025 •
edited
Loading

Here is the final version:
image

Screenshot 2025-02-19 at 2 17 50 PM

andreyvelich
andreyvelich reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaiakash
/lgtm
/assign @kubeflow/kubeflow-steering-committee @juliusvonkohout @franciscojavierarceo

@google-oss-prow google-oss-prow bot added the lgtm label Feb 19, 2025
@franciscojavierarceo
Copy link
Contributor

/lgtm

thanks for this @jaiakash!!!

@juliusvonkohout
Copy link
Member

I think https://github.com/kubeflow/website/pull/3998/files#r1961211039 is still open. maybe we should link both youtube channels otherwise i can approve and merge it. Please tell me if you have further objections.

@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 20, 2025 •
edited
Loading

I think #3998 (files) is still open. maybe we should link both youtube channels otherwise i can approve and merge it. Please tell me if you have further objections.

@juliusvonkohout are you suggesting to add 2 youtube links? Personally i feel one is appropriate.

Moreover, the https://www.youtube.com/@KubeflowCommunity links KubeFlow main youtube, twitter and website.

Screenshot 2025-02-20 at 3 54 35 PM

jaiakash
jaiakash commented Feb 20, 2025
View reviewed changes
Copy link
Contributor Author

@jaiakash jaiakash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final version.

@juliusvonkohout
Copy link
Member

Then please let @andreyvelich approve, since he opened that discussion.

@andreyvelich
Copy link
Member

It looks like formatting at the website is incorrect.
@jaiakash Can you take a look please ?
Screenshot 2025-02-20 at 17 08 29

@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 20, 2025 •
edited
Loading

Hi @andreyvelich, I’m experiencing the same issue when using the Netlify link from the PR.

However, it works fine when I run it locally. Could you confirm if the screenshot you shared is from the Netlify test deployment for this PR?

And how can we verify the correct changes?

@andreyvelich
Copy link
Member

You can check it in the Netlify preview:
https://deploy-preview-3998--competent-brattain-de2d6d.netlify.app/

@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 20, 2025 •
edited
Loading

Yeah i can see netlify preview, but there are differences in local preview and netflify preview. Is there some other configuration that I have to change.

Screen.Recording.2025-02-20.at.10.49.28.PM.mov

@andreyvelich
Copy link
Member

@thesuperzapper Any thoughts ?

@google-oss-prow Google OSS Prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 21, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaiakash
Copy link
Contributor Author

jaiakash commented Feb 21, 2025 •
edited
Loading

Here is something similar i found, https://stackoverflow.com/questions/62616990/fontawesome-icons-not-appearing-when-deploying-website-to-netlify
But i don think that applies to us.

@varodrig
Copy link
Contributor

ks fine when I run it locally. Could you confirm if the screenshot you shared is from the Netlify test deployment for this PR?

I'm experiencing the same using the same the source code locally and I'm not seeing https://x.com/kubeflow/
image

@varodrig
Copy link
Contributor

thanks @jaiakash for working on this.
cc @thesuperzapper to review as well.

@varodrig
Copy link
Contributor

/hold

waiting for updates

@jaiakash jaiakash changed the title [wip]feat: added social media icon on readme and footer feat: added social media icon on readme and footer Feb 25, 2025
@jaiakash jaiakash force-pushed the social-media-icon branch 2 times, most recently from 8b5cfad to a6601a6 Compare February 25, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@andreyvelich andreyvelich andreyvelich left review comments

@varodrig varodrig Awaiting requested review from varodrig

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@franciscojavierarceo franciscojavierarceo

@terrytangyuan terrytangyuan

@hbelmiro hbelmiro

@andreyvelich andreyvelich

@juliusvonkohout juliusvonkohout

@varodrig varodrig

Labels
do-not-merge/hold ok-to-test size/L
Projects
None yet
Milestone
No milestone
8 participants
@jaiakash @franciscojavierarceo @juliusvonkohout @andreyvelich @varodrig @Arhell @terrytangyuan @hbelmiro