Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extents #8

Open
kozbot opened this issue Sep 9, 2017 · 3 comments
Open

Extents #8

kozbot opened this issue Sep 9, 2017 · 3 comments
Assignees

Comments

@kozbot
Copy link
Owner

kozbot commented Sep 9, 2017

Any time a draw method is called it should add to a list for that block rectangle coordinates. From that list we can calculate the actual outer extents plus the block rounded extents which will be needed to implement circuits so symbols don't overlap.

@kozbot kozbot self-assigned this Sep 15, 2017
@kozbot
Copy link
Owner Author

kozbot commented Sep 16, 2017

Can probably move the logic from add_rectangle elsewhere to support calculating the raw extents from as list of points as this basically does the same thing.

@kozbot
Copy link
Owner Author

kozbot commented Feb 11, 2018

Calling this bounds now, and refactoring with this in mind. Going to be integral to each entity type and Groups will return bounds taking into account their children.

@kozbot
Copy link
Owner Author

kozbot commented May 21, 2018

Found that this is blocking SVG and PNG import so moving up in priority. Approximate arc bounds as circles for now so we can get SVG and PNG done. Fix it properly later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant