Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce a MAX_TTL env variable. fix 3524 #3962

Merged
merged 1 commit into from
Aug 28, 2020
Merged

introduce a MAX_TTL env variable. fix 3524 #3962

merged 1 commit into from
Aug 28, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Aug 28, 2020

Fixes #3524

Proposed Changes

  • Add a MAX_TTL variable that allows one to configure the TTL used.

Release Note

- 🎁 Add new feature
Allow MTChannelBroker TTL to be configured via ENV variable.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 28, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2020
n3wscott
n3wscott reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n3wscott
Copy link
Contributor

/retest

@knative-prow-robot knative-prow-robot merged commit e1153b6 into knative:master Aug 28, 2020
@vaikas vaikas deleted the issue-3524 branch August 31, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@grantr grantr Awaiting requested review from grantr

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MTBroker] No way to set default max ttl for events on ingress.
4 participants
@vaikas @knative-prow-robot @n3wscott @googlebot