-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RSA key file support #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution.
I have 2 suggestions:
- Renaming
CONVERT_KEY2RSA
toCONVERT_KEY_TO_RSA
. - As the new flag will affect all keys involved in the extraction process, we should consider renaming it into
CONVERT_KEYS_TO_RSA
(withKEYS
having a plural 's')
I gladly took up your suggestions, see my second commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for applying the suggestions. 👍
Another change that I have to request: #78 was merged recently which introduces a new way of specifying file names and extensions for both certificate and private key file. So you may adjust convert_keys_to_rsa()
accordingly. See my review comments.
Co-authored-by: Kevin Reis <[email protected]>
Co-authored-by: Kevin Reis <[email protected]>
Co-authored-by: Kevin Reis <[email protected]>
Hey ho, I did it similar to #78, should be consistent again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
One tiny thing though: Can you add your new environment variables to the table of README.md? Afterwards, we can go ahead and merge your changes.
I just added the new vars to the table of README.md. Furthermore I added an usage example. Hope this helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I will merge this one. Thank you for your contribution. 😄 👍
You're welcome. Thanks again for your work. :) |
Hello everybody,
some applications (like
mysql
for example) need key files in RSA format. I prepared RSA key conversion using openssl. You can enable it by settingCONVERT_KEY2RSA=yes
.If you think this is useful I'd update the README, too.
Best regards, and thanks for this fantastic tool.
Gregor