Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: victorialogs provider #3700

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ezhil56x
Copy link
Contributor

Closes #3616

πŸ“‘ Description

Added VictoriaLogs Provider for querying VictoriaLogs

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

2025-02-25.19-59-36.mp4

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 25, 2025
Copy link

vercel bot commented Feb 25, 2025

@ezhil56x is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 31.20%. Comparing base (17d8519) to head (94145bb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3700      +/-   ##
==========================================
- Coverage   31.26%   31.20%   -0.06%     
==========================================
  Files          70       70              
  Lines        8250     8270      +20     
==========================================
+ Hits         2579     2581       +2     
- Misses       5671     5689      +18     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Comment on lines +21 to +29
host_url: pydantic.AnyHttpUrl = dataclasses.field(
metadata={
"required": True,
"description": "VictoriaLogs Host URL",
"hint": "e.g. https://victorialogs.example.com",
"sensitive": False,
"validation": "any_http_url",
}
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no auth?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see anything related to auth in their docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it uses the same authentication as victoriametrics provider. all VM components use the same auth

@talboren talboren self-requested a review February 26, 2025 17:57
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
keep βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 26, 2025 6:08pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ”Œ Provider]: VictoriaLogs
3 participants