Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of non-defined 'tag' term #310

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Replace use of non-defined 'tag' term #310

merged 1 commit into from
Oct 10, 2022

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Oct 10, 2022

In the specifications of KQL and JiK, replace the usage of 'tag' with 'type annotation', as that is the term in the main KDL specification.

Close #306

@larsgw
Replace use of non-defined 'tag' term
96af516 
In the specifications of KQL and JiK, replace the
usage of 'tag' with 'type annotation', as that is
the term in the main KDL specification.

Close #306
@larsgw larsgw mentioned this pull request Oct 10, 2022
Closed
@zkat zkat merged commit 0dc4a92 into main Oct 10, 2022
@zkat zkat deleted the larsgw-issue-306 branch October 10, 2022 20:25
@larsgw
Copy link
Contributor Author

larsgw commented Oct 10, 2022

Would you consider labeling this PR hacktoberfest-accepted? I really like their t-shirts, in spite of the problems Hacktoberfest has (and in spite of friends & family generally being confused by the text.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The word ‘tag’ is nowhere defined
2 participants
@larsgw @zkat