KQL: remove map operator and accessors #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly, they're just too implementation-specific
|
My poor heart when I read this just as I finally finished getting my map operator and accessor implementations working 😭 |
|
Map operator is still great, and if implementations want something like that, it makes sense! I just didn't think it made sense for the spec |
fabiancook
added a commit
to virtualstate/kdl
that referenced
this pull request
Feb 20, 2022
|
The individual accessors without the map operator line up very nicely to JSX land concepts. The map operator on the back of the accessors works really well too. Since they have stayed in the spec this long, and map operators are optional now, instead of removing them both, maybe we should just map accessors optional too? I have included both accessors and map operator support in the JSX query engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, they're just too implementation-specific