Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty children aren't reflected in the data model. #219

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Empty children aren't reflected in the data model. #219

merged 2 commits into from
Oct 6, 2021

Conversation

tabatkins
Copy link
Contributor

Closes #218

@hkolbeck
Copy link
Member

hkolbeck commented Oct 5, 2021

Can you add a note to the test README as well?

@tabatkins
Copy link
Contributor Author

That's already in the README due to

  • Node fields should be identifier <values> <properties> <children only if non-empty>

right? That's what made me think that an empty child list should be omitted in the first place.

@hkolbeck
Copy link
Member

hkolbeck commented Oct 6, 2021

Whoops, yep. LGTM

@zkat zkat merged commit 3f293ff into kdl-org:main Oct 6, 2021
@tabatkins tabatkins mentioned this pull request Oct 9, 2021
Closed
@danini-the-panini danini-the-panini mentioned this pull request Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differentiation between "no children" and "empty children"
3 participants
@tabatkins @hkolbeck @zkat