Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider n-grams #25

Open
cmcaine opened this issue Dec 7, 2019 · 0 comments
Open

Consider n-grams #25

cmcaine opened this issue Dec 7, 2019 · 0 comments

Comments

@cmcaine
Copy link

cmcaine commented Dec 7, 2019

At the risk of telling you things you're already well aware of, I'm going to forge ahead with this issue ;)

In the demo, if you search for e.g. "good work is no", then the top results are entries that contain the given words more often, rather than the entry that contains the full phrase "good work is no".

This is expected from the algorithm you describe in your blog post (also, did you realise that you are describing a form of TF-IDF scoring for each term?).

You could improve relevance for these kinds of searches by searching and scoring bigrams or n-grams in addition to individual terms.

I'm not invested in this particularly, (i.e. I don't intend to use this library), but I was browsing your projects and took a look. Maybe these comments are interesting, maybe not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant