Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unwanted commented lines #5851

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jarnura
Copy link
Member

@jarnura jarnura commented Sep 11, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Remove unwanted commented lines

Motivation and Context

Remove unnecessary code

How did you test it?

No code changes done

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@jarnura jarnura added the A-core Area: Core flows label Sep 11, 2024
@jarnura jarnura self-assigned this Sep 11, 2024
@jarnura jarnura requested a review from a team as a code owner September 11, 2024 02:17
Copy link

semanticdiff-com bot commented Sep 11, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Filename Status
✔️ crates/router/src/core/payments.rs Analyzed

SanchithHegde
SanchithHegde previously approved these changes Sep 11, 2024
Base automatically changed from refactor/operation-pd-as-generic to main September 11, 2024 05:50
@Gnanasundari24 Gnanasundari24 dismissed SanchithHegde’s stale review September 11, 2024 05:50

The base branch was changed.

@jarnura jarnura requested review from a team as code owners September 11, 2024 05:50
@jarnura jarnura force-pushed the refactor/operation-pd-as-generic-1 branch from ef0a4a7 to 7167f69 Compare September 11, 2024 06:04
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 4a9fd7e Sep 11, 2024
14 checks passed
@Gnanasundari24 Gnanasundari24 deleted the refactor/operation-pd-as-generic-1 branch September 11, 2024 11:35
pixincreate added a commit that referenced this pull request Sep 13, 2024
* 'main' of github.com:juspay/hyperswitch: (51 commits)
  feat(connector): [DEUTSCHEBANK] Integrate SEPA Payments (#5826)
  feat(payments_v2): payment intent diesel and domain models changes v2 (#5783)
  feat(connector): [Fiuu] ADD Wasm Configs (#5874)
  chore(version): 2024.09.13.0
  refactor(core): Update shipping_cost and order_tax_amount to net_amount of payment_attempt (#5844)
  refactor: return optional request body from build_request_v2 in ConnectorIntegrationV2 trait (#5865)
  feat(refunds): Refunds aggregate api (#5795)
  refactor: handle redirections for iframed content (#5591)
  refactor(payment_links): Update API contract for dynamic transaction details and upgrade UI (#5849)
  fix(router): add payment_method check in `get_mandate_type` (#5828)
  fix(connector): [ZSL] compare consr_paid_amt with the total amount for identifying partial payments (#5873)
  feat(connector): [Novalnet] add Payment flows for cards (#5726)
  chore(version): 2024.09.12.0
  fix(router): return `collect_billing_details_from_wallet_connector` if `always_collect_billing_details_from_wallet_connector ` is false in merchant payment method list (#5854)
  feat(opensearch): add profile_id and organization_id to /search APIs (#5705)
  build(deps): bump `sqlx` to `0.8.2` (#5859)
  refactor: Remove unwanted commented lines (#5851)
  feat(payments): add support for profile aggregates (#5845)
  Feat(connector): [Fiuu] Add DuitNow/FPX PaymentMethod (#5841)
  chore: remove Connectors enum dependency from ConnectorIntegrationV2 trait (#5840)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants