Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(euclid): add a new variant in payment type i.e ppt_mandate #5681

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Aug 23, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This change will add a new variant in payment_type which will be ppt_token_flow using which we will be able to make rule on basis of the ppt flow.

The new variant will be visible here:

Screenshot 2024-08-27 at 3 04 33 PM

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Required for PPT token flow

How did you test it?

Unit test cases are written for the same in PR (vir_interpreter.rs file).

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners August 23, 2024 08:00
Copy link

semanticdiff-com bot commented Aug 23, 2024

Review changes with SemanticDiff.

Analyzed 4 of 4 files.

Overall, the semantic diff is 18% smaller than the GitHub diff.

Filename Status
✔️ crates/router/src/core/payments/routing.rs 52.63% smaller
✔️ crates/euclid/src/enums.rs Analyzed
✔️ crates/euclid/src/backend/vir_interpreter.rs Analyzed
✔️ crates/api_models/src/mandates.rs Analyzed

@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft August 23, 2024 08:00
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 23, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Aug 27, 2024
@prajjwalkumar17 prajjwalkumar17 added this to the August 2024 Release milestone Aug 27, 2024
@prajjwalkumar17 prajjwalkumar17 added C-feature Category: Feature request or enhancement A-euclid-foc Area: Euclid Family of Crates labels Aug 27, 2024
@prajjwalkumar17 prajjwalkumar17 marked this pull request as ready for review August 27, 2024 09:41
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 27, 2024
@prajjwalkumar17 prajjwalkumar17 requested review from vspecky, Aprabhat19 and a team August 27, 2024 09:50
@prajjwalkumar17 prajjwalkumar17 requested review from Sarthak1799 and a team August 27, 2024 10:03
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 350aeb3 Aug 27, 2024
17 of 18 checks passed
@likhinbopanna likhinbopanna deleted the psp_token_refactor branch August 27, 2024 14:35
pixincreate added a commit that referenced this pull request Aug 28, 2024
* 'main' of github.com:juspay/hyperswitch:
  feat(connector): [FISERVEMEA] Integrate cards (#5672)
  ci(cypress): Add routing testcases (#5571)
  fix(router): skip external three_ds flow for recurring payments (#5730)
  refactor(customer_v2): fixed customer_v2 create panic issue (#5699)
  feat(user_roles): support switch for new hierarchy (#5692)
  refactor(router): add domain type for merchant_connector_account id (#5685)
  refactor(cypress_tests): handle api keys check in api key list call (#5719)
  feat(connector): [NEXIXPAY] Add template code (#5684)
  refactor(connector): [itau] refactor error reason and code mapping for itau (#5718)
  fix(core): fix merchant connector account create for v2  (#5716)
  chore(version): 2024.08.28.0
  fix(routing): fix routing routes to deserialise correctly (#5724)
  feat(euclid): add a new variant in payment type i.e ppt_mandate (#5681)
  feat(core): Add mTLS certificates for each request (#5636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-euclid-foc Area: Euclid Family of Crates C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(euclid): create a new variant under payment_type for ppt token flow
5 participants