Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the default JQ_COLORS to use 37, not undefined color 39 #2032

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

DavidBiesack
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Dec 17, 2019

Coverage Status

Coverage decreased (-0.03%) to 84.505% when pulling d43abe4 on DavidBiesack:master into e74eab8 on stedolan:master.

@nicowilliams
Copy link
Contributor

Huh, you're quite right that 39 is not a valid color for vt100, but that is what's used in the source, so correcting the manual is not enough!

$ git grep 0\;39
docs/content/manual/manual.yml:      `"JQ_COLORS=1;30:0;39:0;39:0;39:0;32:1;39:1;39"`.
docs/content/manual/v1.6/manual.yml:      `"JQ_COLORS=1;30:0;39:0;39:0;39:0;32:1;39:1;39"`.
jq.1.prebuilt:The default color scheme is the same as setting \fB"JQ_COLORS=1;30:0;39:0;39:0;39:0;32:1;39:1;39"\fR\.
src/jv_print.c:  {COL("1;30"),    COL("0;39"),      COL("0;39"),     COL("0;39"),

nicowilliams added a commit that referenced this pull request Jan 1, 2020
nicowilliams added a commit that referenced this pull request Jan 2, 2020
nicowilliams added a commit to nicowilliams/jq that referenced this pull request Jan 2, 2020
nicowilliams added a commit to nicowilliams/jq that referenced this pull request Jan 2, 2020
@nicowilliams nicowilliams merged commit 07b18a3 into jqlang:master Jan 2, 2020
@nicowilliams
Copy link
Contributor

Thanks!

nicowilliams added a commit to nicowilliams/jq that referenced this pull request Jan 3, 2020
nicowilliams added a commit to nicowilliams/jq that referenced this pull request Jan 3, 2020
nicowilliams added a commit to nicowilliams/jq that referenced this pull request Jan 3, 2020
nicowilliams added a commit to nicowilliams/jq that referenced this pull request Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants