-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove javax.annotation.Generated as it doesn't ship with Android #577
Comments
Having this annotation is fine in Android because I can mark (for example for future developers of my code) that they can simplify they lives with it so I'd live it - as you can see in SO it can be easily solved in gradle (with adding a dependency) - however it would be nice to have a checkbox to enable/disable generation of this annotation. |
It could be removed for only Android projects by default by adjusting the configuration in |
@farmazon3000 As you say, it's nice to advertise the existence of this project, but this error will waste a lot of engineering time. It's simply not worth sending people to Google and forcing them to add an extra dependency. This annotation hasn't proven useful enough IMO to warrant the annoyance, it's such a trivial thing to break people's projects over. I like the idea of forcing this off for Android projects. I'm happy to introduce a configuration option here and set the default as described by @samskiter. |
+1 for removing this |
More problems caused by having this annotation: https://github.com/andrewkandzuba/jsonschema2pojo-plugin-jdk9 /cc @andrewkandzuba |
FWIW: I actually appreciated the |
The goal of adding this annotation is to let tools know that this is generated source and hence probably shouldn't be considered for things like static code analysis. This annotation doesn't ship with Android's Java though, which causes annoyance for Android developers.
Let's stop adding
javax.annotation.Generated
entirely.The text was updated successfully, but these errors were encountered: