Fix index of calling function argument in lua #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed a bug that the argument becomes illegal when binding SetObj to a member function with argument to lua.
Testcode
struct Foo {
void hoge(int a){}
}
sel::State state;
Foo foo;
state["foo"].SetObj(foo, "hoge", &Foo::hoge);
state("foo:hoge(1)"); // not works
output
[string "foo:hoge(1)"]:1: calling 'hoge' on bad self (number expected, got table),
Cause
_get_args function access sequentially from the bottom of the stack. So, the first argument is assigned 1 for index, but if SetObj is used, table 1 is allocated to index 1 instead of argument. As a result, _check_get function throws GetParameterFromLuaTypeError.
Solution
Access the stack from the top.