Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Item Views #560

Closed
LePips opened this issue Sep 4, 2022 · 0 comments · Fixed by #593
Closed

Dynamic Item Views #560

LePips opened this issue Sep 4, 2022 · 0 comments · Fixed by #593
Labels
enhancement New feature or request

Comments

@LePips
Copy link
Member

LePips commented Sep 4, 2022

Refactor ItemViewModel and corresponding ItemViews so that they take in an item with minimal information (like no overview or chapter information) or an item ID and make a call for the rest of the information, updating the view upon completion. This should optimize calls for many items as we can request a lot less fields instead of FieldItems.allCases.

Criteria:

  • determine the minimum amount of data needed for displaying in a poster or in other smaller contexts
  • Refactor ItemViewModel and ItemViews to accommodate the minimal item and update properly with the new item
@LePips LePips added the enhancement New feature or request label Sep 4, 2022
@LePips LePips changed the title Dynamic Item Requests Dynamic Item Views Sep 4, 2022
@LePips LePips mentioned this issue Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Year, New Video Player + Other Goodies LePips/SwiftFin
1 participant
@LePips