Does not revert when undo

[XO39]

When starting editing a line (or some lines), that line is highlighted as intended, but if I undo the changes, highlighting still there, even if I undo to the starting point and there is nothing to save in the file.

It will be nice if the highlighting disappear for undone changes.

[jcs090218]

Yes, this is a known missing feature. I was trying to implement this but I have not figure out the best solution yet! Thanks for reporting this feature request!

[jcs090218]

Okay, I implemented this feature with few latest commits. Can you upgrade and see if it works? Thanks!

[XO39]

I upgraded to the last version (list-packages U x y), added a space to the end of line then undo, it works for this, but when I make changes then save, there are couple of issues:

1. Color does not change when save
2. It throws Wrong number of arguments: (0 . 0), 1 when save

I had to disable this package temporarily till they are fixed

[jcs090218]

Can you turn on debug-on-error and paste the backtrace of that error? I cannot reproduce this, maybe try uninstall the package cleanly and reinstall it?

I did encounter similar issue in early stages of this feature's implementation. Yet now, I think this issue should already be gone. 😕

[XO39]

(void-variable ind-managed-absolute-indicators)
line-reminder--ind-delete-dups()
line-reminder--before-change-functions(2267 2267)
self-insert-command(1 32)
funcall-interactively(self-insert-command 1 32)
call-interactively(self-insert-command nil nil)
command-execute(self-insert-command)

(wrong-number-of-arguments (0 . 0) 1)
line-reminder--save-buffer(1)
apply(line-reminder--save-buffer 1)
save-buffer(1)
funcall-interactively(save-buffer 1)
call-interactively(save-buffer nil nil)
command-execute(save-buffer)

Got these two kinds of errors

[jcs090218]

(wrong-number-of-arguments (0 . 0) 1)
line-reminder--save-buffer(1)

Okay, I push a fix here. Didn't know save-buffer takes arguments.

(void-variable ind-managed-absolute-indicators)

Not sure how you get this error. I have require indicators at the start of the package enablement. See

https://github.com/jcs-elpa/line-reminder/blob/1856034d0ed8ce41a29a1ea051184ee7c2f3e276/line-reminder.el#L500

Make sure you set line-reminder-show-option before enabling line-reminder-mode.

[XO39]

OK, the errors are gone now.

As for the undo revert functionality, there is still an issue. The marks disappear only if I undo all the way back to the first change in the whole file. It they should be disappear as soon as undoing first change in a line (not in the while file).

[jcs090218]

As for the undo revert functionality, there is still an issue. The marks disappear only if I undo all the way back to the first change in the whole file. It they should be disappear as soon as undoing first change in a line (not in the while file).

Hmm.. I think that's the design? Do you have a reference so I can play around (any editors)? I am using Visual Studio IDE to see the changes, and it only disappears when the file has undo to the root of the node.

[XO39]

Oh, OK, I only use Emacs, and I know you are making it similar to the one used in Visual Studio IDE, but I think the original design is not quite perfect, it it will be much better to make marks disappear per line, I don't know how difficult the implementation is/will be/(cost in performance), but maybe there can be a root per line? For know it's useful but always seek for perfection

[jcs090218]

but maybe there can be a root per line?

Do you mean a sequence of undo changes? I am using undo-tree, and this package currently supports it.

For know it's useful but always seek for perfection

Any suggestions are welcome! As long I understand your needs! 👍

[jcs090218]

I am going to close this issue for now since this is implemented! :)

Feel free to open up another issue for enhancement or suggestions! 👍