Support for the grid mapping attribute and variable #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
RondeauG
changed the title
andersy005
added
the
enhancement
andersy005
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Thank you for your patience, and contribution, @RondeauG! This looks good to me 👍🏽
|
@RondeauG, I also noticed this is your first PR here. Welcome to intake-esm! |
andersy005
reviewed
Mar 7, 2022
|
@andersy005 Sorry to tag you with this, but I just wanted to know if you have an ETA on this PR? Is there something missing and/or anything that I could do to help you with it? Thanks! |
andersy005
reviewed
Apr 19, 2022
More general detection of informational variables Co-authored-by: Anderson Banihirwe <[email protected]>
|
Thank you for this contribution and your patience, @RondeauG! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grid_mappingattribute is used in CF Conventions to link a variable to its grid properties in the case of non-regular grids. These grids are very common for regional climate models. However, the current behaviour of_open_dataset()drops the grid_mapping variable (e.g.rotated_pole), since it is not recognized as arequested_variablesThis small modification searches for the
grid_mappingattribute within therequested_variablesand if found, adds the related variable to the output.