Allow for null values in GH account responses #607
Conversation
nerdalert
commented
Feb 19, 2025
nerdalert
commented
- Github doesn't require names to be added to an account. This avoids throwing an error if a name is not present.
- Emails on GH account can be private. Permit the email field to be empty as well.
- Github doesn't require names to be added to an account. This avoids throwing an error if a name is not present. - Emails on GH account can be private. Permit the email field to be empty as well. Signed-off-by: Brent Salisbury <[email protected]>
| console.error('Failed to fetch GitHub username:', response.status, errorText); | ||
| throw new Error('Failed to fetch GitHub username'); | ||
| console.error('Failed to fetch GitHub email address:', response.status, errorText); | ||
| return ''; |
There was a problem hiding this comment.
@nerdalert DCO sign-off needs Name and public primary email address for DCO sign-off. Otherwise the DCO signoff will fail and user needs to go back and fix the github account to make it pass.
So i am wondering if we should pop-up a warning saying that user needs to setup the name and primary email address for their github account otherwise the DCO sign-off will fail. If press continue, we can set the email/name to empty, and if they press "Fix it", we can direct them to their github profile. Or we can even do the hard enforcement, where if the name and email is not set, we pop-up the warning and don't allow them to contribute knowledge and skill contribution. open for other thoughts as well.
There was a problem hiding this comment.
Just leaving a note from the UI community meeting. Using the masked email for a private email does work for the DCO: instructlab/taxonomy@01cab48 <-- one example
