You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When an overlay is removed from the DOM, the scroll lock classes should be removed from the <body>
Actual Behavior
Works in Web, Android and iOS 16+. But in iOS 15, the scroll lock classes remain present on the <body>, therefore preventing scrolling of the content below.
The overlay is not closed with a close-overlay event, but rather removed from DOM, as you can see in the Stackblitz example.
In iOS 18, the OverlayManager's hide() is called before the remove().
In iOS 15, it is the other way around, first remove(), then hide(), resulting in the following error in the console: 'could not find controller to hide'.
Expected behavior
When an overlay is removed from the DOM, the scroll lock classes should be removed from the
<body>Actual Behavior
Works in Web, Android and iOS 16+. But in iOS 15, the scroll lock classes remain present on the
<body>, therefore preventing scrolling of the content below.The overlay is not closed with a close-overlay event, but rather removed from DOM, as you can see in the Stackblitz example.
In iOS 18, the OverlayManager's
hide()is called before theremove().In iOS 15, it is the other way around, first
remove(), thenhide(), resulting in the following error in the console:'could not find controller to hide'.https://studio.webcomponents.dev/edit/HnMxOof4alHm2BV3Q0EJ/README.md?p=stories
Additional context
lion-dialog
Screenshot in Simulator with iOS 18:
Screenshot in Simulator with iOS 15, showing error:
The text was updated successfully, but these errors were encountered: