Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed definitions in field_metadata #156

Closed
peterdesmet opened this issue May 17, 2021 · 5 comments
Closed

Removed definitions in field_metadata #156

peterdesmet opened this issue May 17, 2021 · 5 comments
Assignees

Comments

@peterdesmet
Copy link
Member

In the new field_metadata table, a number of definitions were removed from the tags_view2 table, even though they still appear in that view:

order  field remark
1  pk
2 tag_id  definition deleted
3 tag_id_alternative
4 telemetry_type
5 manufacturer  definition deleted
6 model  definition deleted
7 frequency
8 type definition deleted
9 serial_number definition deleted
10 tag_id_protocol
11 tag_id_code
12 status
13  activation_date(_time)  called activation_date_time in definitions
23  owner_organization  definition deleted

@aubrivliz Do these reflect updates in the new database?

I also notice that for projects_view2 a new field definition was added, even though it is not in the view:

order  field remark
16  pi_imis_person_id  added
@aubrivliz
Copy link

@peterdesmet Yes this is correct.
For tags_view2:
Manufacturer, model, type, serial_number,owner_organization are now fields on tagDevice you can find the definition there.
Tag_id is the tag's full id, but this should be removed.

For projects_view2:
Pi_imis_person_id is indeed a new field, do you want this added in the view?

@peterdesmet peterdesmet added this to the 0.2.0 milestone May 31, 2021
@aubrivliz
Copy link

@peterdesmet is this still relevant or can this be closed?

@peterdesmet
Copy link
Member Author

peterdesmet commented Nov 23, 2022

The views are used in the etn_fields overview, but we will derive the info directly from app.field_metadata (see #226). I would therefore suggest to remove all _view2 to avoid confusion. Assuming these are not used elsewhere.

  • animals_view2
  • tags_view2
  • detections_view2
  • deployments_view2
  • receivers_view2
  • projects_view2

@peterdesmet
Copy link
Member Author

If the views are deleted, we should also remove the column data_format_field_views_definition from app.field_metadata.

@aubrivliz
Copy link

@peterdesmet the views and col are deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants