Skip to content

Commit 6f4ec34

Browse files
valentinMachadojailln
authored andcommittedMar 6, 2023
fix(view): improve view disposal by removing resize listener
1 parent c83bfcf commit 6f4ec34

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed
 

‎src/Core/View.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,8 @@ class View extends THREE.EventDispatcher {
185185

186186
this._frameRequesters = { };
187187

188-
window.addEventListener('resize', () => this.resize(), false);
188+
this._resizeListener = () => this.resize();
189+
window.addEventListener('resize', this._resizeListener, false);
189190

190191
this._changeSources = new Set();
191192

@@ -258,6 +259,9 @@ class View extends THREE.EventDispatcher {
258259
console.warn('View already disposed');
259260
return;
260261
}
262+
263+
window.removeEventListener('resize', this._resizeListener);
264+
261265
// controls dispose
262266
if (this.controls) {
263267
if (typeof this.controls.dispose === 'function') {

0 commit comments

Comments
 (0)
Please sign in to comment.