Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit locks being leaked #111

Open
BBaoVanC opened this issue Nov 18, 2024 · 6 comments
Open

Inhibit locks being leaked #111

BBaoVanC opened this issue Nov 18, 2024 · 6 comments

Comments

@BBaoVanC
Copy link
Contributor

I don't know the exact cause, but after a while of my system being up, hypridle stops triggering any listeners. It forces me to restart hypridle every so often. If I look at logs, I see a lot of this:

Nov 17 17:59:51 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 17:59:51 bobafw hypridle[520460]: [LOG] Inhibit locks: 1
Nov 17 17:59:51 bobafw hypridle[520460]: [LOG] Cookie 1350 sent
Nov 17 17:59:52 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: false dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 17:59:52 bobafw hypridle[520460]: [LOG] Inhibit locks: 0
Nov 17 17:59:57 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 17:59:57 bobafw hypridle[520460]: [LOG] Inhibit locks: 1
Nov 17 17:59:57 bobafw hypridle[520460]: [LOG] Cookie 1351 sent
Nov 17 17:59:57 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: false dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 17:59:57 bobafw hypridle[520460]: [LOG] Inhibit locks: 0
Nov 17 18:00:06 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:06 bobafw hypridle[520460]: [LOG] Inhibit locks: 1
Nov 17 18:00:06 bobafw hypridle[520460]: [LOG] Cookie 1352 sent
Nov 17 18:00:20 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:20 bobafw hypridle[520460]: [LOG] Inhibit locks: 2
Nov 17 18:00:20 bobafw hypridle[520460]: [LOG] Cookie 1353 sent
Nov 17 18:00:24 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:24 bobafw hypridle[520460]: [LOG] Inhibit locks: 3
Nov 17 18:00:24 bobafw hypridle[520460]: [LOG] Cookie 1354 sent
Nov 17 18:00:25 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:25 bobafw hypridle[520460]: [LOG] Inhibit locks: 4
Nov 17 18:00:25 bobafw hypridle[520460]: [LOG] Cookie 1355 sent
Nov 17 18:00:30 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: false dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:30 bobafw hypridle[520460]: [LOG] Inhibit locks: 3
Nov 17 18:00:30 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:30 bobafw hypridle[520460]: [LOG] Inhibit locks: 4
Nov 17 18:00:30 bobafw hypridle[520460]: [LOG] Cookie 1356 sent
Nov 17 18:00:36 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:36 bobafw hypridle[520460]: [LOG] Inhibit locks: 5
Nov 17 18:00:36 bobafw hypridle[520460]: [LOG] Cookie 1357 sent
Nov 17 18:00:37 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: false dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:37 bobafw hypridle[520460]: [LOG] Inhibit locks: 4
Nov 17 18:00:45 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:45 bobafw hypridle[520460]: [LOG] Inhibit locks: 5
Nov 17 18:00:45 bobafw hypridle[520460]: [LOG] Cookie 1358 sent
Nov 17 18:00:47 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: true dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:47 bobafw hypridle[520460]: [LOG] Inhibit locks: 6
Nov 17 18:00:47 bobafw hypridle[520460]: [LOG] Cookie 1359 sent
Nov 17 18:00:50 bobafw hypridle[520460]: [LOG] ScreenSaver inhibit: false dbus message from firefox (owner: :1.395) with content video-playing
Nov 17 18:00:50 bobafw hypridle[520460]: [LOG] Inhibit locks: 5

Not sure how to debug this further, though. I see a couple issues already mentioning dbus inhibit locks not being freed which are closed, but they seem to just say to update to 0.1.5. I am already on 0.1.5.

@dbckrde
Copy link

dbckrde commented Nov 24, 2024

This issue may be related to Firefox. Scrolling the x/twitter timeline increases the Inhibit lock count (on each video) without decreasing it sometimes. With different browsers, I cannot reproduce this behavior.

@BBaoVanC
Copy link
Contributor Author

BBaoVanC commented Nov 24, 2024

This issue may be related to Firefox. Scrolling the x/twitter timeline increases the Inhibit lock count (on each video) without decreasing it sometimes. With different browsers, I cannot reproduce this behavior.

Bingo. It appears to happen reliably if I scroll through the timeline when there's sequential videos in the timeline. If a video autoplays while one is already playing, it leaks an inhibit lock.

I'll see if it happens on any other browsers, but this seems like it would be a browser-level bug. If so, then I'll look for or create a Firefox bug.


Edit: Actually, I'll see if I can read the dbus events. I suspect that maybe you aren't supposed to count inhibits incrementally.

@grappas
Copy link
Contributor

grappas commented Nov 24, 2024

@BBaoVanC - I can see similar behavior in GNOME. It seems to be DE agnostic bug strictly related to Firefox.

@BBaoVanC
Copy link
Contributor Author

@BBaoVanC - I can see similar behavior in GNOME. It seems to be DE agnostic bug strictly related to Firefox.

Can you write that on the Bugzilla issue? They are thinking it's Hyprland only issue

@grappas
Copy link
Contributor

grappas commented Feb 20, 2025

Can you write that on the Bugzilla issue? They are thinking it's Hyprland only issue

I already did.

@BBaoVanC
Copy link
Contributor Author

Hmm, I don't see any reply from you or mentioning it also not working on GNOME as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants