-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Migrate from OpenCensus to OpenTelemetry #2169
Conversation
Not sure how to address the issue with protobuf, could it be that |
About the Go version, I see #2125 downgraded it from 1.23 to 1.21. Even if the repo goes with the last N-2 versions as opposed to the Go release policy of N-1 that would still be valid to bump it to 1.22 now. Let's wait for a maintainer's input on this. |
We have upgraded the Min Go version to 1.22 here #2171. Please upgrade the opentelemetry to the latest and we would be happy to merge the PR. Thank you for creating the PR. |
OTel dependencies upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spelling mistake! LGTM otherwise. @harshil-goel for final review before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two more comments, we are good to merge otherwise! And resolve the conflicts as well. Thank you.
Description
Migrate from OpenCensus to OpenTelemetry, doing some adjustements where there is no 1:1 migration path:
zpages
handler explicitly added tohttp.DefaultServeMux
, aszpages.Handle()
is not available anymore.I am also adjusting some uses of spans in compactions, so their annotations are not overwritten on every call to
runCompactDef
in cases where it is called multiple times.Not using latest version of OpenTelemetry because it requires Go 1.22, and badger still supports 1.21.
Fix #2155.
Checklist
CHANGELOG.md
file describing and linking tothis PR