Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disc is using the wrong buffer #9

Closed
feross opened this issue Feb 19, 2014 · 3 comments
Closed

Disc is using the wrong buffer #9

feross opened this issue Feb 19, 2014 · 3 comments

Comments

@feross
Copy link
Contributor

feross commented Feb 19, 2014

Since browserify 3.0, the Buffer from https://github.com/feross/buffer is used, which is much smaller (around 35kb instead of 100kb). Also, browser-builtins is no longer used.

(This is also potentially relevant to issue #7)
@hughsk
Copy link
Owner

hughsk commented Feb 23, 2014

Yeah, the way disc currently works means its easy for it to fall behind. I'm close to having a 1.0.0 release ready which uses browser-unpack instead, just waiting on browserify/browserify#668 to get merged first :)

@feross
Copy link
Contributor Author

feross commented Feb 23, 2014

Excellent, thanks!

@hughsk
Copy link
Owner

hughsk commented Mar 23, 2014

Should be fixed! Feel free to reopen if it's not working for you :)

@hughsk hughsk closed this as completed Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feross @hughsk