-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImageProcessorFast to Qwen2.5-VL processor #36164
Conversation
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@@ -900,7 +943,7 @@ class Qwen2_5_VLProcessor(Qwen2VLProcessor): | |||
in a chat into a tokenizable string. | |||
""" | |||
|
|||
image_processor_class = "Qwen2_5_VLImageProcessor" | |||
image_processor_class = "AutoImageProcessor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most needed!
src/transformers/models/qwen2_5_vl/image_processing_qwen2_5_vl.py
Outdated
Show resolved
Hide resolved
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks 🤗
@@ -6442,7 +6441,6 @@ | |||
PoolFormerImageProcessor, | |||
) | |||
from .models.pvt import PvtImageProcessor | |||
from .models.qwen2_5_vl import Qwen2_5_VLImageProcessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not breaking because we added it in this release!
Hi @Isotr0py could you please update https://huggingface.co/Qwen/Qwen2.5-VL-7B-Instruct/blob/main/preprocessor_config.json according to this PR's modification? I use the latest version of transformers and it gives error:
|
It has been fixed at the hf repo: https://huggingface.co/Qwen/Qwen2.5-VL-7B-Instruct/blob/main/preprocessor_config.json |
@hiyouga Thanks for feedback! Just opened PR in model's repo for update: https://huggingface.co/Qwen/Qwen2.5-VL-7B-Instruct/discussions/24 |
What does this PR do?
Qwen2_5_VLImageProcessorFast
to Qwen2.5-VL modular fileBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yonigozlan @ArthurZucker