Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRA can not be used in text encoder in "train_text_to_image_lora.py"? #2469

Closed
ZihaoW123 opened this issue Feb 23, 2023 · 5 comments
Closed
Labels

Comments

@ZihaoW123
Copy link

It can be seen from [(https://github.com/cloneofsimo/lora)] that fine-tuning the lora for the text encoder works better than the lora for unet. When will this repo support the lora of the text encoder?
image

@haofanwang
Copy link
Contributor

haofanwang commented Feb 23, 2023

This PR can support it!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 25, 2023
@patrickvonplaten patrickvonplaten added wip and removed stale Issues that haven't received updates labels Mar 28, 2023
@patrickvonplaten
Copy link
Contributor

cc @sayakpaul think this is being worked on no?

@sayakpaul
Copy link
Member

sayakpaul commented Mar 28, 2023

Actively. Latest update: #2719 (comment)

The community script supports it already, though with the use of peft.

@sayakpaul
Copy link
Member

Closing this as we support loading of LoRA into a text encoder when relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants