Duplicated value exception

[hmedat]

I have these functions:
@NeedsPermission({Manifest.permission.CAMERA,Manifest.permission.WRITE_EXTERNAL_STORAGE})
public void showCamera() {
}
@OnPermissionDenied({Manifest.permission.CAMERA,Manifest.permission.WRITE_EXTERNAL_STORAGE})
void onShowCameraDenied() {
}

@OnNeverAskAgain({Manifest.permission.CAMERA,Manifest.permission.WRITE_EXTERNAL_STORAGE})
void onShowCameraNeverAsk() {
}

@NeedsPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE)
void showGetStorage() {
}

@OnPermissionDenied(Manifest.permission.WRITE_EXTERNAL_STORAGE)
void onGetStorageDenied() {
}

@OnNeverAskAgain(Manifest.permission.WRITE_EXTERNAL_STORAGE)
void onGetStorageNeverAsk() {
}

---

These Functions to show camera and show gallery picker

As you know camera app needs to permissions (Camera,Storage), and gallery app only need storage permission.

In three first functions to manage with camera permissions, and the other function to manage gallery permission

The Bug is:

You provide me to set multiple permission with camera and storage in NeedsPermission annotation, but you prevent me to set them in OnPermissionDenied and OnNeverAskAgain annotations.

This is an error:
Error:Execution failed for task ':app:compileStagingDebugJavaWithJavac'.

permissions.dispatcher.processor.exception.DuplicatedValueException: [android.permission.WRITE_EXTERNAL_STORAGE] is duplicated in 'onGetStorageDenied()' annotated with '@OnPermissionDenied'

Thanks in advance.

[hmedat]

@aurae

[mannodermaus]

I can verify that the duplicate detection is off for the code you provided, which should be working, but isn't.

[hmedat]

So?

[mannodermaus]

So, we will be resolving the issue in an upcoming release.

[hmedat]

So Thank you :)

[mannodermaus]

83b0a35 fixes this, so that this problem will be resolved in the next release.

[hmedat]

Can you give me the release time?, because i need this fix urgently

[mannodermaus]

@hotchemi Could you prepare an artifact for 2.0.2?

[hotchemi]

@aurae I think the test fails...

[mannodermaus]

The test suite passes in its entirety on my machine (using gradle cleanTest test testV13 --tests *). What error are you getting?

[hotchemi]

$ ./gradlew clean test
:library:clean
:processor:clean
:sample:clean UP-TO-DATE
:library:compileLint
:library:copyDebugLint UP-TO-DATE
:library:preBuild UP-TO-DATE
:library:preDebugBuild UP-TO-DATE
:library:checkDebugManifest
:library:preDebugAndroidTestBuild UP-TO-DATE
:library:preDebugUnitTestBuild UP-TO-DATE
:library:preReleaseBuild UP-TO-DATE
:library:preReleaseUnitTestBuild UP-TO-DATE
:library:prepareComAndroidSupportSupportV132311Library
:library:prepareComAndroidSupportSupportV42311Library
:library:prepareDebugDependencies
:library:compileDebugAidl
:library:compileDebugRenderscript
:library:generateDebugBuildConfig
:library:generateDebugAssets UP-TO-DATE
:library:mergeDebugAssets
:library:generateDebugResValues UP-TO-DATE
:library:generateDebugResources
:library:mergeDebugResources
:library:processDebugManifest
:library:processDebugResources
:library:generateDebugSources
:library:processDebugJavaRes UP-TO-DATE
:library:compileDebugJavaWithJavac
:library:extractDebugAnnotations
:library:mergeDebugProguardFiles UP-TO-DATE
:library:packageDebugJar
:library:compileDebugNdk UP-TO-DATE
:library:packageDebugJniLibs UP-TO-DATE
:library:packageDebugLocalJar UP-TO-DATE
:library:packageDebugRenderscript UP-TO-DATE
:library:packageDebugResources
:library:bundleDebug
:library:compileDebugSources
:library:assembleDebug
:library:copyReleaseLint UP-TO-DATE
:library:checkReleaseManifest
:library:prepareReleaseDependencies
:library:compileReleaseAidl
:library:compileReleaseRenderscript
:library:generateReleaseBuildConfig
:library:generateReleaseAssets UP-TO-DATE
:library:mergeReleaseAssets
:library:generateReleaseResValues UP-TO-DATE
:library:generateReleaseResources
:library:mergeReleaseResources
:library:processReleaseManifest
:library:processReleaseResources
:library:generateReleaseSources
:library:processReleaseJavaRes UP-TO-DATE
:library:compileReleaseJavaWithJavac
:library:extractReleaseAnnotations
:library:mergeReleaseProguardFiles UP-TO-DATE
:library:packageReleaseJar
:library:compileReleaseNdk UP-TO-DATE
:library:packageReleaseJniLibs UP-TO-DATE
:library:packageReleaseLocalJar UP-TO-DATE
:library:packageReleaseRenderscript UP-TO-DATE
:library:packageReleaseResources
:library:bundleRelease
:library:compileReleaseSources
:library:assembleRelease
:library:javadoc
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:11: error: package android.support.annotation does not exist
import android.support.annotation.Nullable;
                                 ^
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:12: error: package android.support.v4.app does not exist
import android.support.v4.app.ActivityCompat;
                             ^
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:13: error: package android.support.v4.util does not exist
import android.support.v4.util.SimpleArrayMap;
                              ^
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:20: error: package android.support.v4.content does not exist
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
                                        ^
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:20: error: static import only from classes and interfaces
import static android.support.v4.content.PermissionChecker.checkSelfPermission;
^
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:26: error: cannot find symbol
    private static final SimpleArrayMap<String, Integer> MIN_SDK_PERMISSIONS;
                         ^
  symbol:   class SimpleArrayMap
  location: class PermissionUtils
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/v13/V13Access.java:4: error: package android.support.v13.app does not exist
import android.support.v13.app.FragmentCompat;
                              ^
/Users/01004107/workspace/other/PermissionsDispatcher/library/src/main/android/permissions/dispatcher/PermissionUtils.java:109: error: cannot find symbol
    public static @Nullable Intent createAppSettingsIntent(Context context) {
                   ^
  symbol:   class Nullable
  location: class PermissionUtils
javadoc: warning - Class Nullable not found.
javadoc: warning - Class Nullable not found.
javadoc: warning - Class Nullable not found.
javadoc: warning - Class Nullable not found.
javadoc: warning - Class Nullable not found.
javadoc: warning - Class Nullable not found.
14 warnings
:library:javadocJar
:library:sourcesJar
:library:assemble
:library:lint
Ran lint on variant release: 7 issues found
Ran lint on variant debug: 7 issues found
Wrote HTML report to file:/Users/01004107/workspace/other/PermissionsDispatcher/library/build/outputs/lint-results.html
Wrote XML report to /Users/01004107/workspace/other/PermissionsDispatcher/library/build/outputs/lint-results.xml
:library:prepareDebugUnitTestDependencies
:library:processDebugUnitTestJavaRes UP-TO-DATE
:library:compileDebugUnitTestJavaWithJavac
:library:compileDebugUnitTestSources
:library:mockableAndroidJar
:library:assembleDebugUnitTest
:library:testDebugUnitTest
:library:prepareReleaseUnitTestDependencies
:library:processReleaseUnitTestJavaRes UP-TO-DATE
:library:compileReleaseUnitTestJavaWithJavac
:library:compileReleaseUnitTestSources
:library:assembleReleaseUnitTest
:library:testReleaseUnitTest
:library:test
:library:check
:library:build
:processor:compileKotlin
:processor:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.7
1 warning
:processor:processResources
:processor:classes
:processor:jar
:processor:javadoc
:processor:javadocJar
:processor:sourcesJar
:processor:assemble
:processor:compileTestKotlin
No Kotlin files found, skipping Kotlin compiler task
:processor:compileTestJava
warning: [options] bootstrap class path not set in conjunction with -source 1.7
:processor:processTestResources UP-TO-DATE
:processor:testClasses
:processor:test

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithOtherDeniedActivity                                                                     FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:295

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithOtherDeniedFragment                                                                     FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:299

permissions.dispatcher.processor.ProcessorTestSuite > noDuplicatesDespiteRepeatedValuesActivity                                                                FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:312

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithNeverAskActivity                                                                       FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:191

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersRationaleAndDeniedActivity                                                    FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:155

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersAndDeniedSupportFragment                                                      FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:167

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureAndDeniedActivity                                                         FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:207

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionActivity FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:135

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionFragment FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:139

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithOneRationaleActivity                                                                   FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:263

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskRationaleAndDeniedActivity                                                      FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:183

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureRationaleAndDeniedSupportFragment                                         FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:227

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithDeniedActivity                                                                          FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:287

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithDeniedFragment                                                                          FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:291

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsSupportFragment                                                                            FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:235

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureAndRationaleActivity                                                      FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:203

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskAndRationaleActivity                                                            FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:179

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithTwoRationalesActivity                                                                  FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:271

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskAndDeniedSupportFragment                                                        FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:259

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersAndRationaleSupportFragment                                                   FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:163

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskSupportFragment                                                                 FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:255

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskActivity                                                                        FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:175

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithRationaleAndDeniedActivity                                                              FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:303

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersAndRationaleActivity                                                          FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:147

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureRationaleAndDeniedActivity                                                FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:211

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithTwoRationalesSupportFragment                                                           FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:275

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureSupportFragment                                                           FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:215

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersRationaleAndDeniedSupportFragment                                             FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:171

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithOtherRationaleActivity                                                                  FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:279

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureAndDeniedSupportFragment                                                  FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:223

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureActivity                                                                  FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:199

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithRationaleAndDeniedSupportFragment                                                       FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:307

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersSupportFragment                                                               FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:159

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithOtherRationaleSupportFragment                                                           FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:283

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithRationaleSupportFragment                                                                FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:243

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithOneRationaleSupportFragment                                                            FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:267

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskAndDeniedActivity                                                               FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:187

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersAndDeniedActivity                                                             FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:151

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskAndRationaleSupportFragment                                                     FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:247

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithParametersActivity                                                                      FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:143

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsActivity FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:195

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithRationaleActivity                                                                       FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:239

permissions.dispatcher.processor.ProcessorTestSuite > onePermissionWithNeverAskRationaleAndDeniedSupportFragment                                               FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:251

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsAtOnceActivity                                                                             FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:231

permissions.dispatcher.processor.ProcessorTestSuite > twoPermissionsWithSameSignatureAndRationaleSupportFragment                                               FAILED
    java.lang.AssertionError at ProcessorTestSuite.java:219

72 tests completed, 45 failed
:processor:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':processor:test'.
> There were failing tests. See the report at: file:///Users/01004107/workspace/other/PermissionsDispatcher/processor/build/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 15.664 secs

[hotchemi]

Sorry, I've not dived into the detail yet.

[mannodermaus]

The failing test cases are related to another issue with the Copy task that prepares the library's sources for the processor's test suite. I'm opening a new issue on this.

edit: tracking in #64

[hmedat]

Any updates?