Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-31758: Store when a node is removed in the raft stable store #29090

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

miagilepner
Copy link
Contributor

@miagilepner miagilepner commented Dec 4, 2024

Description

This PR has a raft node write to its stable store when it's been removed. When a raft backend is created, the backend reads this value from the stable store to set the removed flag. If you try to add back a raft node that's been removed to a cluster, it will error (instead of returning a successful status without doing anything).

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.19.0-rc milestone Dec 4, 2024
@miagilepner miagilepner requested a review from a team as a code owner December 4, 2024 16:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 4, 2024

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner marked this pull request as draft December 4, 2024 16:57
@miagilepner miagilepner marked this pull request as ready for review December 5, 2024 11:19
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miagilepner miagilepner merged commit 9bde015 into main Dec 11, 2024
135 checks passed
@miagilepner miagilepner deleted the miagilepner/VAULT-31758-write-removed-to-stable branch December 11, 2024 11:32
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
…29090)

* implementation and test

* changelog

* verify servers are healthy before removing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants