-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of VAULT-32330: fix sanitize path function to account for backslashes into release/1.18.x #28897
Backport of VAULT-32330: fix sanitize path function to account for backslashes into release/1.18.x #28897
Conversation
578bd1a
to
92e91b9
Compare
CI Results: |
Build Results: |
@aslamovamir If the backport PR could be auto-generated, then you don't need to assign us as reviewers, you can review it yourself (just a sanity check)! You only need to add others if it was a manual backport. |
Hi @VioletHynes and @divyaac ! |
Yup, sorry! I added as a reviewer to clarify some points, I added them. But got the note - thanks for clarifying! |
For 1.16, you will need to perform the backport manually (make a branch locally and cherry-pick the commit). But in general, I'd expect 3 PRs to be generated by the three labels. |
For 1.16, are you referring to this automated PR on the enterprise vault repo? So no need to backport to 1.16 on OSS vault repo, just the enterprise vault repo? Removed the tag for version 1.17.x ent and added it again and the automated PR got generated: https://github.com/hashicorp/vault-enterprise/pull/6982#event-15286856315 |
…mmensely-shining-seasnail
Backport
This PR is auto-generated from #28878 to be assessed for backporting due to the inclusion of the label backport/1.18.x.
The below text is copied from the body of the original PR.
Description
What does this PR do?
Fixes a backslash check in logical_system.go by expanding the check to also include filtering for double forward and back slashes.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+ent
labels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.x
label, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
Overview of commits