Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Usage Enablement for Ent-Feature CMPv2 #28237

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Conversation

kitography
Copy link
Contributor

Description

KeyUsage added as a field to intermediate and root certificates.
This enables ent-feature for CMPv2 to work.
https://github.com/hashicorp/vault-enterprise/pull/6492/files#

TODO only if you're a HashiCorp employee

  • Not a backport
  • Not a security
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files. - PR already exists
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@kitography kitography requested a review from a team as a code owner August 30, 2024 16:05
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 30, 2024
@kitography kitography added this to the 1.18.0-rc milestone Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Aug 30, 2024

Build Results:
All builds succeeded! ✅

Copy link
Collaborator

@sgmiller sgmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you go ahead and add the docs updates for this?

@kitography
Copy link
Contributor Author

Can you go ahead and add the docs updates for this?

Docs are added.

Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kitography kitography enabled auto-merge (squash) August 30, 2024 16:49
@kitography kitography merged commit edf6851 into main Aug 30, 2024
79 checks passed
@kitography kitography deleted the VAULT-28055-key-usage branch August 30, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants