Backport of PKI: Do not set NextUpdate OCSP field when ocsp_expiry is 0 into release/1.15.x #24196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-22097-ocsp-nextupdate/commonly-thorough-jaybird
branch
from
3e2a874 to
a705592
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-22097-ocsp-nextupdate/commonly-thorough-jaybird
branch
from
b51c05b to
1f7f045
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
stevendpclark
approved these changes
Nov 20, 2023
|
Build Results: |
stevendpclark
deleted the
backport/stevendpclark/vault-22097-ocsp-nextupdate/commonly-thorough-jaybird
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24192 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
When the
ocsp_expiryfield within config/crl is set to 0, we should not be setting theNextUpdatefield within OCSP responses. We were setting it to the current time, which effectively means that the response has expired and shouldn't be used.Based on RFC 6960: 4.2.2.1. Time, we shouldn't have set this field to indicate newer information is available right away
Overview of commits