Displays Auth Method description on Vault UI login page #11795
Conversation
| @@ -26,6 +26,10 @@ | |||
| @errorMessage={{if (and cluster.standby hasCSPError) cspErrorText error}} | |||
| data-test-auth-error | |||
| /> | |||
| <div class="has-bottom-margin-s "> | |||
| <p class="is-label"> {{this.selectedAuthBackend.path}}</p> | |||
There was a problem hiding this comment.
super small comment, but no spaces after the closing element. In the line below too, I noticed a space before and after the opening and closing span tags. e.g >space{{this.selectedAuthBackend....
There was a problem hiding this comment.
@Monkeychip - thank you for pointing this out! I wasn't sure which was correct 😅
|
Also, I forgot you'll need to do a changelog. If you look at the main vault repo (e.g. it's a folder higher than the ui folder) there are files inside a folder called changelog. Files are named after the pr. So for example there is a file called: 11500.txt. with the following inside: The 11500 is the PR number. In this case your pr number is 11795 so you'll make a .txt file called 11795.txt in the changelog folder with a description of this pr. This will also be an improvement like my example. |
Adds description beneath path name
