Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(targets): remove deprecated fields on target api/cli/sdk and service #1533

Merged
merged 1 commit into from
Jun 15, 2022
Merged

chore(targets): remove deprecated fields on target api/cli/sdk and service #1533

merged 1 commit into from
Jun 15, 2022

Conversation

louisruch
Copy link
Collaborator

@louisruch louisruch commented Sep 17, 2021 •
edited
Loading

Removes credential libraries with respect to target resources

@louisruch
Copy link
Collaborator Author

@jefferai @talanknight PTAL this removes deprecated fields from the target domain
@mgaffney @tmessi FYI/PTAL

@louisruch
Copy link
Collaborator Author

louisruch commented Sep 17, 2021 •
edited
Loading

Tagging @randallmorey to confirm the UI has moved to sources

@ghost
Copy link

ghost commented Sep 17, 2021

@louisruch working on this update today. To clarify, the UI will change to *-sources, but we do not support multiple source types just yet.

talanknight
talanknight reviewed Sep 17, 2021
View reviewed changes
Copy link
Contributor

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do a database migration for any grants which were previously on sets and libraries and change them to sources?

@jefferai
Copy link
Member

I'm not sure re: migrations, only because it might take a bit if people have a lot of roles. OTOH, people are unlikely to have a lot of roles right now. :-)

So yeah, I think we do want to migrate, and disallow new grants from being saved using the deprecated actions.

@louisruch
Copy link
Collaborator Author

louisruch commented Sep 17, 2021 •
edited
Loading

I'm not sure re: migrations, only because it might take a bit if people have a lot of roles. OTOH, people are unlikely to have a lot of roles right now. :-)

So yeah, I think we do want to migrate, and disallow new grants from being saved using the deprecated actions.

I removed the *-credential_library actions from the map so they would be disallowed. However, I noticed that host-sets actions were shared with host_set repo, so I actually removed the DEPRECATED comment on them. Not sure what impact this will have on migrations now that I think about it

@ghost
Copy link

ghost commented Sep 17, 2021 •
edited by ghost
Loading

Looks like FE will need Monday to complete the transition to *-sources fields.

@louisruch louisruch added this to the 0.7.0 milestone Sep 20, 2021
@louisruch louisruch marked this pull request as draft September 22, 2021 20:43
@ghost
Copy link

ghost commented Sep 24, 2021

FE has now migrated to *-sources hashicorp/boundary-ui#770

@jefferai jefferai modified the milestones: 0.7.0, 0.7.4 Jan 3, 2022
@jefferai jefferai modified the milestones: 0.7.4, 0.7.5 Jan 13, 2022
@jefferai jefferai modified the milestones: 0.7.5, 0.7.6 Mar 11, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jefferai jefferai modified the milestones: 0.7.6, 0.8.0 Apr 6, 2022
@louisruch louisruch marked this pull request as ready for review June 14, 2022 20:23
@louisruch louisruch requested a review from talanknight June 14, 2022 20:23
@louisruch
Copy link
Collaborator Author

@jefferai @talanknight PTAL

@louisruch louisruch requested review from johanbrandhorst and removed request for jefferai and talanknight June 14, 2022 22:36
@louisruch louisruch modified the milestones: 0.8.0, 0.9.0 Jun 15, 2022
johanbrandhorst
johanbrandhorst approved these changes Jun 15, 2022
View reviewed changes
internal/daemon/controller/handlers/targets/target_service.go
Comment on lines +608 to +609
// TODO AddCredentialLibraries was deprecated but grant actions were never migrated
// remove this check once actions have been migrated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you mentioned this, but do we have a ticket for migrating grant actions?

@louisruch louisruch merged commit 68eb6e2 into main Jun 15, 2022
@louisruch louisruch deleted the louis-cleanup branch June 15, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talanknight talanknight talanknight left review comments

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
api/targets api core/gen core/proto core/types core
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@louisruch @jefferai @hashicorp-cla @talanknight @johanbrandhorst