fix: show lighthouse runtime error when re-queuing failed routes #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For me, an absent NODE_EXTRA_CA_CERTS environment variable caused the lighthouse tasks to fail due to invalid TLS certificates after an upgrade in a containerized environment. In that case, the existing error message wasn't helpful, because the same URL worked fine on the host where the certificate was correctly installed and picked up.
👷 Deploy request for unlighthouse-crux-api pending review.Visit the deploys page to approve it
|
|
I don't think my issue was related to #203, because there the route is eventually successful after some failed attempts. This wasn't the case for my TLS certificate mis-configuration. But this change may help anyways, if lighthouse sets the runtime error field there. |
harlan-zw
changed the title
|
Good idea, thanks! Will get a release out a bit later today most likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me, an absent NODE_EXTRA_CA_CERTS environment variable caused the lighthouse tasks to fail due to invalid TLS certificates after an upgrade in a containerized environment. In that case, the existing error message wasn't helpful, because the same URL worked fine on the host where the certificate was correctly installed and picked up.