-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsconfig/base.json file missing in v0.12.2 #218
Comments
getting an error since upgrading to 12.2 this morning that I think is related here. My unlighthouse.config file was working great before upgrading: (node:691801) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension. SyntaxError: Unexpected token 'export' Node.js v18.20.2 |
Also getting the same error as @y2gabs Running Will revert to the previous version with |
Thank you for the reports, I'm trying to replicate but having issues. I'm not exactly sure what's going on, maybe related to an upstream dependency or 0c6a0eb. Could you try |
@harlan-zw it's the same issue using npx directly:
|
Forgot to mention that I'm using npx directly too. I just specify 0.12.1 in my scan and it works for now. This is such a great tool so thank you for all you do! |
@y2gabs how are you doing that? (what command)? As |
Using it in bash - npx [email protected] |
weird hit & miss issues running 0.12.1 this week unfortunately. Scan only seems to run half the time, the other half it seems to hang during the scan. Weird |
I'm able to reproduce the Failed GitHub Action FYR: https://github.com/mwskwong/mwskwong.com/actions/runs/9573986998/job/26396439815 Workflow name: Unlighthouse
on: deployment_status
jobs:
unlighthouse:
if: github.event_name == 'deployment_status' && github.event.deployment_status.state == 'success'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- run: npm install -g @unlighthouse/cli puppeteer
- run: npm list -g @unlighthouse/cli
- run: unlighthouse-ci --site ${{ github.event.deployment_status.environment_url }}
- uses: actions/upload-artifact@v4
if: always()
with:
path: ./.unlighthouse
export default {
cache: false,
ci: {
buildStatic: true,
budget: {
performance: 95,
accessibility: 92,
'best-practices': 100,
seo: 66,
},
},
scanner: {
samples: 5,
},
}; |
@harlan-zw Running In my case, I'm running VM scale sets in ADO. If a job is in the queue for 5 minutes, new VM is provisioned. In this scenario However, if I run |
After thorough testing, I'm positive this is a dependency issue. After moving from Node v18 to Node v20, specifically v20.15.1, this issue no longer appears. I can run |
Describe the bug
In ADO pipeline, I run
npm install -g @unlighthouse/cli puppeteer
andunlighthouse-ci --site $(deploymentUrl) --config-file unlighthouse-desktop.config.ts --debug --output-path $(System.DefaultWorkingDirectory)/$(VERCEL_PROJECT_NAME)-lighthouse
. Since 0.12.2 release, I get this error:Reverting to v0.12.1 solves the issue
Reproduction
No response
System / Nuxt Info
No response
The text was updated successfully, but these errors were encountered: