fix: false positive redirect warning for trailing slash

harlan-zw · harlan-zw · commit ef34b9150301 · 2024-10-16T13:41:51.000+11:00
diff --git a/packages/core/src/puppeteer/tasks/html.ts b/packages/core/src/puppeteer/tasks/html.ts
@@ -128,7 +128,7 @@ export const inspectHtmlTask: PuppeteerTask = async (props) => {
         return routeReport
       }
       // ignore redirect from site to site/
-      if (withoutTrailingSlash(response.redirected) !== runtimeSettings.siteUrl.href)
+      if (withoutTrailingSlash(response.redirected) !== withoutTrailingSlash(runtimeSettings.siteUrl.href))
         logger.info('Redirected url detected, this may cause issues in the final report.', response.redirected)
 
       // check if redirect url is already queued, if so we bail on this route

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ export const inspectHtmlTask: PuppeteerTask = async (props) => {`
`128`	`128`	`return routeReport`
`129`	`129`	`}`
`130`	`130`	`// ignore redirect from site to site/`
`131`		`- if (withoutTrailingSlash(response.redirected) !== runtimeSettings.siteUrl.href)`
	`131`	`+ if (withoutTrailingSlash(response.redirected) !== withoutTrailingSlash(runtimeSettings.siteUrl.href))`
`132`	`132`	`logger.info('Redirected url detected, this may cause issues in the final report.', response.redirected)`
`133`	`133`
`134`	`134`	`// check if redirect url is already queued, if so we bail on this route`