Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty system prompt shouldn't be rejected. #4

Open
buczek opened this issue Feb 26, 2025 · 2 comments
Open

Empty system prompt shouldn't be rejected. #4

buczek opened this issue Feb 26, 2025 · 2 comments
Labels
usage Improve usability

Comments

@buczek
Copy link

buczek commented Feb 26, 2025

Currently, the webgui requires a system prompt and shows the error ("System prompt is required") if you try to set it to empty 1. However recommendation for Deepseek is to have an empty system prompt 2. I suggest the validation to be removed.

Footnotes

  1. https://github.com/gwdg/chat-ai/blob/3cec71999bfc5f1961e1f0d78c4d86d24ec7f942/front/src/components/Chat/SettingsPanel.jsx#L160]

  2. https://huggingface.co/deepseek-ai/DeepSeek-R1/blob/main/README.md#usage-recommendations

@adoosth
Copy link
Collaborator

adoosth commented Feb 27, 2025

Thanks, this is a valid point, but for some other models you can get a bad request error if you send a message without a system prompt.

Perhaps having a warning message (e.g. Warning: the system prompt is empty) instead of outright rejecting it would be better; if the user gets a bad request error they will probably understand why.

@buczek
Copy link
Author

buczek commented Feb 27, 2025

Perhaps failures caused by model specific requirements which currently return "bad request" can be turned into a more sensible error message ("This model requires a non-empty system message")? Model specific validation of input should not be done in the GUI frontend, but further down the pipeline, though.

Instead of validation, the system prompt could also be defaulted to an empty string when absent for those models which require it. Personally, I'd prefer a validation over a fixup, because it keeps the user informed and doesn't do magic behind the scenes.

@adoosth adoosth added the usage Improve usability label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usage Improve usability
Projects
None yet
Development

No branches or pull requests

2 participants