Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the method_name for the CallCredentials callback generateMetadata #2814

Conversation

becoded
Copy link
Contributor

@becoded becoded commented Aug 29, 2024

The method name is required to create valid SIGv4 authenticated requests for Amazon VPC Lattice.

This is available in multiple implementations (c++, Golang, PHP).
See also

Copy link

linux-foundation-easycla bot commented Aug 29, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@becoded
Copy link
Contributor Author

becoded commented Sep 4, 2024

Hello @murgatroid99

Do you know when this could be taken up into a new release?
Thanks in advance!

@becoded
Copy link
Contributor Author

becoded commented Sep 10, 2024

Hello @murgatroid99 , is there anything that I can do to retrigger that test that timed out?

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about that test job. Sorry for the delay handling this. I was out for an unexpectedly long time and I'm still getting caught up. This looks like a reasonable change to me.

@murgatroid99 murgatroid99 merged commit 605f14a into grpc:master Sep 10, 2024
4 of 5 checks passed
@becoded
Copy link
Contributor Author

becoded commented Sep 11, 2024

Thx for picking it up! I'm looking forward to seeing it pop up in a new release.

(I hope everything is fine with you by the way.)

@becoded becoded deleted the call-credential-generate-metadata-method-name branch September 11, 2024 13:48
@becoded
Copy link
Contributor Author

becoded commented Sep 18, 2024

Hello @murgatroid99,
I was happy to see this morning that there was a new release yesterday.
Sadly enough, the changes of this MR aren't included in that release even though the changes are in master since last week.
Do you have any idea when these changes are going to be included in a release?

Thx in advance.

@murgatroid99
Copy link
Member

The new release was a patch release. This is an API change so it will go out in the next minor release. I don't currently know when that will be, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants