Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.68: remove opentelemetry module and pull into main module #7936

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Dec 16, 2024

RELEASE NOTES (will need to be manual):

Dependencies

  • Remove the experimental stats/opentelemetry module and instead add the experimental packages it contains directly into the main google.golang.org/grpc module.

@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Dec 16, 2024
@dfawley dfawley added this to the 1.68 Release milestone Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.00%. Comparing base (7d2cf55) to head (d132952).
Report is 1 commits behind head on v1.68.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.68.x    #7936      +/-   ##
===========================================
+ Coverage    81.60%   82.00%   +0.39%     
===========================================
  Files          364      370       +6     
  Lines        35914    37251    +1337     
===========================================
+ Hits         29306    30546    +1240     
- Misses        5400     5467      +67     
- Partials      1208     1238      +30     

see 24 files with indirect coverage changes

@dfawley
Copy link
Member Author

dfawley commented Dec 16, 2024

FYI this should address our side of googleapis/google-cloud-go#11283

@purnesh42H
Copy link
Contributor

@dfawley how will this help the storage library who uses older version of grpc who are still looking for separate opentelemetry module in stats? I am assuming they have to update to the patch release?

@dfawley
Copy link
Member Author

dfawley commented Dec 17, 2024

I am assuming they have to update to the patch release?

Correct. If they update to a version with this change then their users won't run into conflicts with our latest release.

@dfawley dfawley merged commit 2c1bf69 into grpc:v1.68.x Dec 17, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants