Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove a TODO that has been take care of #7855

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Nov 18, 2024

This was taken care of in #7653

RELEASE NOTES: none

@easwars easwars requested a review from dfawley November 18, 2024 23:58
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Nov 18, 2024
@easwars easwars added this to the 1.69 Release milestone Nov 18, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (d7f27c4) to head (3d72ce1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7855      +/-   ##
==========================================
+ Coverage   81.88%   81.90%   +0.01%     
==========================================
  Files         374      374              
  Lines       37993    37993              
==========================================
+ Hits        31110    31117       +7     
+ Misses       5586     5581       -5     
+ Partials     1297     1295       -2     
Files with missing lines Coverage Δ
rpc_util.go 79.48% <ø> (ø)

... and 16 files with indirect coverage changes

---- 🚨 Try these New Features:

@dfawley dfawley assigned easwars and unassigned dfawley Nov 19, 2024
@easwars easwars merged commit 0775031 into grpc:master Nov 19, 2024
15 checks passed
@easwars easwars deleted the remove_todo branch November 19, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants