Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle dns resolver error for localhost #7672

Closed
wants to merge 1 commit into from

Conversation

antonyj7
Copy link

No description provided.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (bcf9171) to head (e672c88).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/resolver/dns/dns_resolver.go 21.42% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7672      +/-   ##
==========================================
+ Coverage   81.79%   82.00%   +0.20%     
==========================================
  Files         361      361              
  Lines       27821    27831      +10     
==========================================
+ Hits        22757    22823      +66     
+ Misses       3863     3828      -35     
+ Partials     1201     1180      -21     
Files with missing lines Coverage Δ
internal/resolver/dns/dns_resolver.go 86.36% <21.42%> (-4.51%) ⬇️

... and 27 files with indirect coverage changes

@purnesh42H
Copy link
Contributor

purnesh42H commented Sep 29, 2024

@antonyj7 we usually don't do draft PRs on main repo. I am assuming its a follow up PR for the issue of facing delay in dns lookup for localhost. If you want us to validate your approach, you can provide a proposal or link a PR from your fork in the issue #7429

@purnesh42H purnesh42H closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants