Fix route_instance_path

[pcreux]

route_instance_path was not working with nested resources (the one that use belongs_to). It's now fixed.

route_instance_path was returning a symbol like :admin_post_path while route_collection_path was returning the path like /admin/posts. route_instance_path now returns the path.

I also refactored the route generation into RouteBuilder.

🍰

[seanlinsley]

Cool, thanks. Are there any Github Issues that are associated with this?

Why is all this needed in the first place? Why can't we build our objects so they act like the objects that the Rails router expects, so we don't have to do any routing at all?

[seanlinsley]

BTW, I won't be able to do an in-depth review of this until Sunday at least.

[pcreux]

What do you mean by building objects like the ones the Rails router expects?

[seanlinsley]

I mean that in vanilla Rails you can just link_to the_resource_obj_instance and you're done.

[pcreux]

Right. This only works when Rails can guess the route from the model name: User.find(1) => /users/1. So it only works if your resource is registered in the :root namespace.

The following would not work:

• ActiveAdmin.register User, as: "Person"
• or belongs_to: :manager
• or namespace: :admin.

This was needed to fix auto_link for nested associations. I also also use it to build links in email notifications.

There is no Github issue.

[seanlinsley]

There's no need to symbolize the key before lookup. The params hash is a HashWithIndifferentAccess which means that the keys are stored as strings, but if you look up a symbol it will convert it to a string before doing a search.

[seanlinsley]

@pcreux what does it mean for a route to be "uncountable"? I've never understood that.

[seanlinsley]

Nevermind, I figured it out myself. For posterity, here's a useful link, and my findings.

# our code
def route_uncountable?
  config = controller.resources_configuration[:self]
  config[:route_collection_name] == config[:route_instance_name]
end

# on the console
AdminUsersController.resources_configuration[:self]
 => {:route_collection_name=>:admin_users, :route_instance_name=>:admin_user, etc.}

# if we mark "admin_user" as an uncountable word with Rails,
ActiveSupport::Inflector.inflections do |inflect|
  inflect.uncountable %w(admin_user)
end

# then the configuration changes as such (after server restart)
AdminUserController.resources_configuration[:self]
 => {:route_collection_name=>:admin_user, :route_instance_name=>:admin_user, etc.}

# Since Rails (for some unknown reason) adds _index to the named route for the index page
# of an uncountable resource, this bit in our route lookup is necessary
resource.route_uncountable? ? 'index_path' : 'path'

[seanlinsley]

... @macfanatic what's the point of even doing a PR if you're going to accept code and not have concerns addressed before it's pulled in?