Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enable Redis+Cluster since RediSearch works in cluster with the right plugin. #807

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

martinhoch42
Copy link

@martinhoch42 martinhoch42 commented Feb 27, 2024

Redis cluster support was removed in #645 for the reason:

Remove Redis cluster support since RediSearch is unavailable on Redis cluster.

This appears to be incorrect or outdated. RediSearch can be built with RediSearch Coordinator and then works in a Redis+Cluster.

See: https://forum.redis.com/t/anything-to-do-to-get-redisearch-to-search-across-clusters/1943/6

This information is a bit hard to find but I am running a test setup for gorse 0.4 with a redis+cluster without noticeable problems.

6) 1) "name"
   2) "search"
   3) "ver"
   4) (integer) 20811
   5) "path"
   6) "/opt/redis-stack/contrib/lib/module-oss.so"
   7) "args"
   8) (empty list or set)

The main branch is broken for me, so I am working based off 0.4 and am submitting the pull request for 0.4 as well.

@zhenghaoz
Copy link
Collaborator

Thank you

@zhenghaoz zhenghaoz merged commit 1b41312 into gorse-io:release-0.4 Feb 28, 2024
8 of 9 checks passed
@martinhoch42 martinhoch42 deleted the release-0.4 branch February 29, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants